Removing unused (3)

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/sections/PersonSectionImpl.java

@@ -39,7 +39,7 @@ public class PersonSectionImpl implements PersonSection {
         personSectionHeader.write(person);
         clearExistingTimeLineData.clear();
         gatherTimeLineData.gather(person);
-        personSubSectionTimeLineWriter.write(person);
-        personSubSectionReferencesWriter.write(person);
+        personSubSectionTimeLineWriter.write();
+        personSubSectionReferencesWriter.write();
     }
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/PersonSubSectionReferencesWriter.java

@@ -5,9 +5,7 @@
 
 package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections;
 
-import scot.carricksoftware.grantswriter.domains.people.Person;
-
 public interface PersonSubSectionReferencesWriter {
 
-    void write(@SuppressWarnings("unused") Person person);
+    void write();
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/PersonSubSectionReferencesWriterImpl.java

@@ -6,7 +6,6 @@
 package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections;
 
 import org.springframework.stereotype.Component;
-import scot.carricksoftware.grantswriter.domains.people.Person;
 import scot.carricksoftware.grantswriter.writer.latex.LatexSubSectionHeader;
 import scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.helpers.WriteReferences;
 
@@ -24,7 +23,7 @@ public class PersonSubSectionReferencesWriterImpl implements PersonSubSectionRef
     }
 
     @Override
-    public void write(Person person) {
+    public void write() {
         latexSubSectionHeader.write("References");
         writeReferences.write();
     }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/PersonSubSectionTimeLineWriter.java

@@ -5,8 +5,6 @@
 
 package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections;
 
-import scot.carricksoftware.grantswriter.domains.people.Person;
-
 public interface PersonSubSectionTimeLineWriter {
-    void write(@SuppressWarnings("unused") Person person);
+    void write();
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/PersonSubSectionTimeLineWriterImpl.java

@@ -8,7 +8,6 @@ package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.springframework.stereotype.Component;
-import scot.carricksoftware.grantswriter.domains.people.Person;
 import scot.carricksoftware.grantswriter.writer.latex.LatexSubSectionHeader;
 import scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.helpers.WriteTimeLine;
 
@@ -28,9 +27,8 @@ public class PersonSubSectionTimeLineWriterImpl implements PersonSubSectionTimeL
     }
 
     @Override
-    public void write(Person person) {
+    public void write() {
         logger.info("PersonSubSectionTimeLineWriterImp::write");
-
         latexSubSectionHeader.write("Timeline");
         writeTimeLine.write();
     }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/DateSortTreeMap.java

@@ -1,15 +0,0 @@
-/*
- * Copyright (c) 2025.  Andrew Grant Carrick Software. All rights reserved
- *
- */
-
-package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.helpers;
-
-import java.util.List;
-import java.util.TreeMap;
-
-public interface DateSortTreeMap {
-
-    @SuppressWarnings({"EmptyMethod", "unused"})
-    void sort(TreeMap<String, List<String>> map);
-}

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/DateSortTreeMapImpl.java

@@ -1,17 +0,0 @@
-/*
- * Copyright (c) 2025.  Andrew Grant Carrick Software. All rights reserved
- *
- */
-
-package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.helpers;
-
-import java.util.List;
-import java.util.TreeMap;
-
-public class DateSortTreeMapImpl implements DateSortTreeMap {
-
-    @Override
-    public void sort(TreeMap<String, List<String>> map) {
-
-    }
-}

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/GatherBirthCertificateTimeLineData.java

@@ -8,5 +8,6 @@ package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.
 import scot.carricksoftware.grantswriter.domains.people.Person;
 
 public interface GatherBirthCertificateTimeLineData {
-   void gather(@SuppressWarnings("unused") Person person);
+
+   void gather(Person person);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/GatherBirthCertificateTimeLineDataImpl.java

@@ -49,7 +49,6 @@ public class GatherBirthCertificateTimeLineDataImpl implements GatherBirthCertif
         gatherInformant(person);
     }
 
-    @SuppressWarnings("unused")
     private void gatherNewBorn(Person person) {
         List<BirthCertificate> birthCertificates = birthCertificateService.findAllByNewBorn(person);
         if (!birthCertificates.isEmpty()) {
@@ -58,19 +57,19 @@ public class GatherBirthCertificateTimeLineDataImpl implements GatherBirthCertif
     }
 
     @SuppressWarnings("unused")
-    private void gatherFather(@SuppressWarnings("unused") Person person) {
+    private void gatherFather(Person person) {
         List<BirthCertificate> birthCertificates = birthCertificateService.findAllByFather(person);
         gatherBirthCertificateFatherTimeLineData.gather(birthCertificates);
     }
 
     @SuppressWarnings("unused")
-    private void gatherMother(@SuppressWarnings("unused") Person person) {
+    private void gatherMother(Person person) {
         List<BirthCertificate> birthCertificates = birthCertificateService.findAllByMother(person);
         gatherBirthCertificateMotherTimeLineData.gather(birthCertificates);
     }
 
     @SuppressWarnings("unused")
-    private void gatherInformant(@SuppressWarnings("unused") Person person) {
+    private void gatherInformant(Person person) {
         List<BirthCertificate> birthCertificates = birthCertificateService.findAllByInformant(person);
         gatherBirthCertificateInformantTimeLineData.gather(birthCertificates);
     }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/GatherDeathCertificateTimeLineData.java

@@ -8,5 +8,5 @@ package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.
 import scot.carricksoftware.grantswriter.domains.people.Person;
 
 public interface GatherDeathCertificateTimeLineData {
-   void gather(@SuppressWarnings("unused") Person person);
+   void gather(Person person);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/GatherDivorceCertificateTimeLineData.java

@@ -8,5 +8,5 @@ package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.
 import scot.carricksoftware.grantswriter.domains.people.Person;
 
 public interface GatherDivorceCertificateTimeLineData {
-   void gather(@SuppressWarnings("unused") Person person);
+   void gather(Person person);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/GatherMarriageCertificateTimeLineData.java

@@ -8,5 +8,5 @@ package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.
 import scot.carricksoftware.grantswriter.domains.people.Person;
 
 public interface GatherMarriageCertificateTimeLineData {
-   void gather(@SuppressWarnings("unused") Person person);
+   void gather(Person person);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/deathcertificate/GatherDeathCertificateDeceasedTimeLineDataImpl.java

@@ -39,7 +39,6 @@ public class GatherDeathCertificateDeceasedTimeLineDataImpl implements GatherDea
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(DeathCertificate deathCertificate) {
         timelineData.getRefs().add("Death Certificate for : " + deathCertificate.getDeceased().toString());
     }
@@ -61,7 +60,6 @@ public class GatherDeathCertificateDeceasedTimeLineDataImpl implements GatherDea
 
     }
 
-    @SuppressWarnings("unused")
     private void addWhereRegistered(TreeMap<DMY, List<String>> timeLine, DeathCertificate deathCertificate) {
         logger.info("GatherDeathCertificateDeceasedTimeLineDataImpl::AddWhenRegistered");
 
@@ -86,7 +84,6 @@ public class GatherDeathCertificateDeceasedTimeLineDataImpl implements GatherDea
             } else {
                 informant = deathCertificate.getUntrackedInformant();
             }
-            var debug = deathCertificate.getWhereRegistered();
             existingValues.add("Death registered by " + informant + " at " + whereRegistered);
             timeLine.put(getDMY(deathCertificate.getWhenRegistered()), existingValues);
         }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/deathcertificate/GatherDeathCertificateInformantTimeLineDataImpl.java

@@ -37,13 +37,10 @@ public class GatherDeathCertificateInformantTimeLineDataImpl implements GatherDe
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(DeathCertificate deathCertificate) {
         timelineData.getRefs().add("Death Certificate for : " + deathCertificate.getDeceased().toString());
     }
 
-
-    @SuppressWarnings("unused")
     private void addRegisteredTheDeath(TreeMap<DMY, List<String>> timeLine, DeathCertificate deathCertificate) {
         logger.info("GatherDeathCertificateInformantTimeLineDataImpl::AddWhenRegistered");
 

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/divorcecertificate/GatherDivorceCertificateFirstPartyTimeLineData.java

@@ -10,6 +10,6 @@ import scot.carricksoftware.grantswriter.domains.certificates.divorcecertificate
 import java.util.List;
 
 public interface GatherDivorceCertificateFirstPartyTimeLineData {
-   @SuppressWarnings("unused")
+
    void gather(List<DivorceCertificate> divorceCertificates);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/divorcecertificate/GatherDivorceCertificateFirstPartyTimeLineDataImpl.java

@@ -43,7 +43,6 @@ public class GatherDivorceCertificateFirstPartyTimeLineDataImpl implements Gathe
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(DivorceCertificate divorceCertificate) {
         timelineData.getRefs().add("Divorce Certificate for : " + divorceCertificate.getFirstParty() + " and " + divorceCertificate.getSecondParty());
     }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/divorcecertificate/GatherDivorceCertificateSecondPartyTimeLineData.java

@@ -10,6 +10,6 @@ import scot.carricksoftware.grantswriter.domains.certificates.divorcecertificate
 import java.util.List;
 
 public interface GatherDivorceCertificateSecondPartyTimeLineData {
-   @SuppressWarnings("unused")
+
    void gather(List<DivorceCertificate> divorceCertificates);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/divorcecertificate/GatherDivorceCertificateSecondPartyTimeLineDataImpl.java

@@ -41,7 +41,6 @@ public class GatherDivorceCertificateSecondPartyTimeLineDataImpl implements Gath
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(DivorceCertificate divorceCertificate) {
         timelineData.getRefs().add("Divorce Certificate for : " + divorceCertificate.getFirstParty() + " and " + divorceCertificate.getSecondParty());
     }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/marriagecertificate/GatherMarriageCertificateBrideTimeLineDataImpl.java

@@ -42,12 +42,8 @@ public class GatherMarriageCertificateBrideTimeLineDataImpl implements GatherMar
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(MarriageCertificate marriageCertificate) {
-        var vz = timelineData.getRefs();
         timelineData.getRefs().add("Marriage Certificate for : " + marriageCertificate.getBride() + " and " + marriageCertificate.getGroom());
-        var vx = timelineData.getRefs();
-        int deb = -1;
     }
 
     private void addWhenMarried(TreeMap<DMY, List<String>> timeLine, MarriageCertificate marriageCertificate) {

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/marriagecertificate/GatherMarriageCertificateFirstWitnessTimeLineData.java

@@ -10,6 +10,6 @@ import scot.carricksoftware.grantswriter.domains.certificates.marriagecertificat
 import java.util.List;
 
 public interface GatherMarriageCertificateFirstWitnessTimeLineData {
-   @SuppressWarnings("unused")
+
    void gather(List<MarriageCertificate> marriageCertificates);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/marriagecertificate/GatherMarriageCertificateFirstWitnessTimeLineDataImpl.java

@@ -42,7 +42,6 @@ public class GatherMarriageCertificateFirstWitnessTimeLineDataImpl implements Ga
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(MarriageCertificate marriageCertificate) {
         timelineData.getRefs().add("Marriage Certificate for : " + marriageCertificate.getBride() + " and " + marriageCertificate.getGroom());
     }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/marriagecertificate/GatherMarriageCertificateGroomTimeLineDataImpl.java

@@ -41,9 +41,7 @@ public class GatherMarriageCertificateGroomTimeLineDataImpl implements GatherMar
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(MarriageCertificate marriageCertificate) {
-        var z = timelineData.getRefs();
         timelineData.getRefs().add("Marriage Certificate for : " + marriageCertificate.getBride() + " and " + marriageCertificate.getGroom());
     }
 

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/marriagecertificate/GatherMarriageCertificateSecondWitnessTimeLineData.java

@@ -10,6 +10,6 @@ import scot.carricksoftware.grantswriter.domains.certificates.marriagecertificat
 import java.util.List;
 
 public interface GatherMarriageCertificateSecondWitnessTimeLineData {
-   @SuppressWarnings("unused")
+
    void gather(List<MarriageCertificate> marriageCertificates);
 }

src/main/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/level2/marriagecertificate/GatherMarriageCertificateSecondWitnessTimeLineDataImpl.java

@@ -39,7 +39,6 @@ public class GatherMarriageCertificateSecondWitnessTimeLineDataImpl implements G
         }
     }
 
-    @SuppressWarnings("unused")
     private void addRefs(MarriageCertificate marriageCertificate) {
         timelineData.getRefs().add("Marriage Certificate for : " + marriageCertificate.getBride() + " and " + marriageCertificate.getGroom());
     }

src/test/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/sections/PersonSectionTest.java

@@ -65,7 +65,7 @@ class PersonSectionTest {
         inorder.verify(personSectionHeaderMock).write(personMock);
         inorder.verify(clearExistingTimeLineDataMock).clear();
         inorder.verify(gatherTimeLineDataMock).gather(personMock);
-        inorder.verify(personSubSectionTimeLineWriterMock).write(personMock);
-        inorder.verify(personSubSectionReferencesWriterMock).write(personMock);
+        inorder.verify(personSubSectionTimeLineWriterMock).write();
+        inorder.verify(personSubSectionReferencesWriterMock).write();
     }
 }

src/test/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/sections/PersonSubSectionReferencesWriterTest.java

@@ -10,7 +10,6 @@ import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-import scot.carricksoftware.grantswriter.domains.people.Person;
 import scot.carricksoftware.grantswriter.writer.latex.LatexSubSectionHeader;
 import scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.PersonSubSectionReferencesWriter;
 import scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.PersonSubSectionReferencesWriterImpl;
@@ -26,9 +25,6 @@ class PersonSubSectionReferencesWriterTest {
     @Mock
     private LatexSubSectionHeader latexSubSectionHeaderMock;
 
-    @Mock
-    private Person personMock;
-
     @Mock
     private WriteReferences writeReferencesMock;
 
@@ -39,7 +35,7 @@ class PersonSubSectionReferencesWriterTest {
 
     @Test
     void writeTest() {
-        writer.write(personMock);
+        writer.write();
         verify(latexSubSectionHeaderMock).write("References");
     }
 }

src/test/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/PersonSubSectionReferencesWriterTest.java

@@ -13,7 +13,6 @@ import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.InOrder;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-import scot.carricksoftware.grantswriter.domains.people.Person;
 import scot.carricksoftware.grantswriter.writer.latex.LatexSubSectionHeader;
 import scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.helpers.WriteReferences;
 
@@ -31,8 +30,6 @@ class PersonSubSectionReferencesWriterTest {
     @Mock
     private WriteReferences writeReferencesMock;
 
-    @Mock
-    private Person personMock;
 
     @BeforeEach
     void setUp() {
@@ -43,7 +40,7 @@ class PersonSubSectionReferencesWriterTest {
     void writeTest() {
         InOrder inOrder = inOrder(latexSubSectionHeaderMock, writeReferencesMock);
 
-        personSubSectionReferencesWriter.write(personMock);
+        personSubSectionReferencesWriter.write();
         inOrder.verify(latexSubSectionHeaderMock).write("References");
         inOrder.verify(writeReferencesMock).write();
     }

src/test/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/PersonSubSectionTimeLineWriterTest.java

@@ -11,7 +11,6 @@ import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.InOrder;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-import scot.carricksoftware.grantswriter.domains.people.Person;
 import scot.carricksoftware.grantswriter.writer.latex.LatexSubSectionHeader;
 import scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.helpers.WriteTimeLine;
 
@@ -28,9 +27,6 @@ class PersonSubSectionTimeLineWriterTest {
     @Mock
     private WriteTimeLine writeTimeLineMock;
 
-    @Mock
-    private Person personMock;
-
     @BeforeEach
     void setUp() {
         writer = new PersonSubSectionTimeLineWriterImpl(
@@ -42,7 +38,7 @@ class PersonSubSectionTimeLineWriterTest {
     void writeHeaderTest() {
         InOrder inOrder = inOrder(latexSubSectionHeaderMock, writeTimeLineMock);
 
-        writer.write(personMock);
+        writer.write();
         inOrder.verify(latexSubSectionHeaderMock).write("Timeline");
         inOrder.verify(writeTimeLineMock).write();
     }

src/test/java/scot/carricksoftware/grantswriter/writer/latex/parts/people/subsections/helpers/DateSortTreeMapTest.java

@@ -1,27 +0,0 @@
-/*
- * Copyright (c) 2025.  Andrew Grant Carrick Software. All rights reserved
- *
- */
-
-package scot.carricksoftware.grantswriter.writer.latex.parts.people.subsections.helpers;
-
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
-
-class DateSortTreeMapTest {
-    private DateSortTreeMap dateSortTreeMap;
-
-    @BeforeEach
-    void setUp() {
-        dateSortTreeMap = new DateSortTreeMapImpl();
-    }
-
-    @Test
-    void constructorTest() {
-        assertNotNull(dateSortTreeMap);
-    }
-
-}