Forráskód Böngészése

UpdatedCertifiedYearOfBirthTest::nullPersonCommand

Andrew Grant 5 hónapja
szülő
commit
37a649c929

+ 1 - 1
src/main/java/scot/carricksoftware/grants/services/certificates/birthcertificates/UpdateCertifiedYearOfBirthImpl.java

@@ -58,7 +58,7 @@ public class UpdateCertifiedYearOfBirthImpl implements UpdateCertifiedYearOfBirt
     }
 
     private void logNoCommandError() {
-        throw new NullPointerException("Person Command is null.");
+        logger.error("PersonCommand = null.");
     }
 
 

+ 19 - 3
src/test/java/scot/carricksoftware/grants/services/certificates/birthcertificates/UpdateCertifiedYearOfBirthTest.java

@@ -10,13 +10,20 @@ import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
+import org.springframework.boot.test.system.CapturedOutput;
+import org.springframework.boot.test.system.OutputCaptureExtension;
 import scot.carricksoftware.grants.commands.certificates.birthcertificates.BirthCertificateCommand;
 import scot.carricksoftware.grants.converters.people.PersonConverter;
+import scot.carricksoftware.grants.domains.people.Person;
 import scot.carricksoftware.grants.services.people.PersonService;
 
-import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.verifyNoInteractions;
+import static org.mockito.Mockito.when;
 
+@ExtendWith(OutputCaptureExtension.class)
 @ExtendWith(MockitoExtension.class)
 class UpdateCertifiedYearOfBirthTest {
 
@@ -31,6 +38,7 @@ class UpdateCertifiedYearOfBirthTest {
     @Mock
     private BirthCertificateCommand birthCertificateCommandMock;
 
+
     @BeforeEach
     void setUp() {
         updateCertifiedYearOfBirth = new UpdateCertifiedYearOfBirthImpl(personConverterMock, personServiceMock);
@@ -43,7 +51,15 @@ class UpdateCertifiedYearOfBirthTest {
     }
 
     @Test()
-    void nullPersonCommandTest() {
-        assertThrows(NullPointerException.class, () -> updateCertifiedYearOfBirth.updateCertifiedYearOfBirth(null));
+    void nullPersonCommandTest(CapturedOutput capturedOutput) {
+
+        when(birthCertificateCommandMock.getNewBorn()).thenReturn(new Person());
+        when(birthCertificateCommandMock.getWhenBorn()).thenReturn("25/01/1953 01:01)");
+        when(personConverterMock.convert(any())).thenReturn(null);
+
+        updateCertifiedYearOfBirth.updateCertifiedYearOfBirth(birthCertificateCommandMock);
+
+        assertTrue(capturedOutput.getOut().contains("PersonCommand = null."));
     }
+
 }