Przeglądaj źródła

UpdateRecordedYearOfBirthImpl does not work with no Person

Andrew Grant 7 miesięcy temu
rodzic
commit
3bd1d926ce

+ 2 - 4
src/main/java/scot/carricksoftware/grants/services/census/censusentry/UpdateRecordedYearOfBirthImpl.java

@@ -57,7 +57,7 @@ public class UpdateRecordedYearOfBirthImpl implements UpdateRecordedYearOfBirth
             }
 
         } else {
-            logNoPersonError();
+            logger.info("Cannot update recorded year of birth - person is null");
         }
 
     }
@@ -78,7 +78,5 @@ public class UpdateRecordedYearOfBirthImpl implements UpdateRecordedYearOfBirth
         throw new NullPointerException("Person Command is null.");
     }
 
-    private void logNoPersonError() {
-        throw new NullPointerException("Person is null.");
-    }
+
 }

+ 0 - 72
src/test/java/scot/carricksoftware/grants/services/census/censusentry/UpdateRecordedYearThrowsTest.java

@@ -1,72 +0,0 @@
-/*
- * Copyright (c) 2025.  Andrew Grant Carrick Software. All rights reserved
- *
- */
-
-package scot.carricksoftware.grants.services.census.censusentry;
-
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.extension.ExtendWith;
-import org.mockito.Mock;
-import org.mockito.junit.jupiter.MockitoExtension;
-import scot.carricksoftware.grants.commands.census.CensusEntryCommand;
-import scot.carricksoftware.grants.converters.people.PersonConverter;
-import scot.carricksoftware.grants.domains.people.Person;
-import scot.carricksoftware.grants.services.people.PersonService;
-
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.mockito.Mockito.when;
-import static scot.carricksoftware.grants.GenerateCertificateRandomValues.GetRandomString;
-
-@ExtendWith(MockitoExtension.class)
-class UpdateRecordedYearThrowsTest {
-
-    private UpdateRecordedYearOfBirth updateRecordedYearOfBirth;
-
-
-    @Mock
-    private PersonService personServiceMock;
-
-    @Mock
-    private CensusEntryCommand censusEntryCommandMock;
-
-    @Mock
-    private PersonConverter personConverterMock;
-
-    @Mock
-    private Person personMock;
-
-
-    @BeforeEach
-    void setUp() {
-        updateRecordedYearOfBirth = new UpdateRecordedYearOfBirthImpl(personConverterMock, personServiceMock);
-    }
-
-    @Test
-    public void noPersonIsThrownTest() {
-        Exception exception = assertThrows(NullPointerException.class,
-                () -> updateRecordedYearOfBirth.updateRecordedYearOfBirth(censusEntryCommandMock));
-
-        String expectedMessage = "Person is null.";
-        String actualMessage = exception.getMessage();
-        assertTrue(actualMessage.contains(expectedMessage));
-    }
-
-    @Test
-    public void noPersonCommandIsThrownTest() {
-        when(censusEntryCommandMock.getPerson()).thenReturn(personMock);
-        when(censusEntryCommandMock.getBirthYear()).thenReturn(GetRandomString());
-        when(personConverterMock.convert(personMock)).thenReturn(null);
-        Exception exception = assertThrows(NullPointerException.class,
-                () -> updateRecordedYearOfBirth.updateRecordedYearOfBirth(censusEntryCommandMock));
-
-        String expectedMessage = "Person Command is null.";
-        String actualMessage = exception.getMessage();
-        assertTrue(actualMessage.contains(expectedMessage));
-    }
-
-
-
-}