Browse Source

UpdateRecordedYearThrowsTest (2)

Andrew Grant 7 months ago
parent
commit
fbe627e555

+ 2 - 1
src/main/java/scot/carricksoftware/grants/services/census/censusentry/UpdateRecordedYearOfBirthImpl.java

@@ -53,6 +53,7 @@ public class UpdateRecordedYearOfBirthImpl implements UpdateRecordedYearOfBirth
                     }
                 }
             }
+
         } else {
             logNoPersonError();
         }
@@ -72,7 +73,7 @@ public class UpdateRecordedYearOfBirthImpl implements UpdateRecordedYearOfBirth
     }
 
     private void logNoCommandError(){
-        throw new NullPointerException("Person Command is null");
+        throw new NullPointerException("Person Command is null.");
     }
 
     private void logNoPersonError(){

+ 20 - 0
src/test/java/scot/carricksoftware/grants/services/census/censusentry/UpdateRecordedYearThrowsTest.java

@@ -12,10 +12,13 @@ import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 import scot.carricksoftware.grants.commands.census.CensusEntryCommand;
 import scot.carricksoftware.grants.converters.people.PersonConverter;
+import scot.carricksoftware.grants.domains.people.Person;
 import scot.carricksoftware.grants.services.people.PersonService;
 
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.when;
+import static scot.carricksoftware.grants.GenerateCertificateRandomValues.GetRandomString;
 
 @ExtendWith(MockitoExtension.class)
 class UpdateRecordedYearThrowsTest {
@@ -32,6 +35,9 @@ class UpdateRecordedYearThrowsTest {
     @Mock
     private PersonConverter personConverterMock;
 
+    @Mock
+    private Person personMock;
+
     @BeforeEach
     void setUp() {
         updateRecordedYearOfBirth = new UpdateRecordedYearOfBirthImpl(personConverterMock, personServiceMock);
@@ -47,5 +53,19 @@ class UpdateRecordedYearThrowsTest {
         assertTrue(actualMessage.contains(expectedMessage));
     }
 
+    @Test
+    public void noPersonCommandIsThrownTest() {
+        when(personMock.getRecordedYearOfBirth()).thenReturn(null);
+        when(censusEntryCommandMock.getPerson()).thenReturn(personMock);
+        when(censusEntryCommandMock.getBirthYear()).thenReturn(GetRandomString());
+        Exception exception = assertThrows(NullPointerException.class,
+                () -> updateRecordedYearOfBirth.updateRecordedYearOfBirth(censusEntryCommandMock));
+
+        String expectedMessage = "Person Command is null.";
+        String actualMessage = exception.getMessage();
+        assertTrue(actualMessage.contains(expectedMessage));
+    }
+
+
 
 }